docs: improve azurerm_firewall_policy example usage#32172
Closed
yosofbadr wants to merge 1 commit intohashicorp:mainfrom
Closed
docs: improve azurerm_firewall_policy example usage#32172yosofbadr wants to merge 1 commit intohashicorp:mainfrom
yosofbadr wants to merge 1 commit intohashicorp:mainfrom
Conversation
Add a comprehensive example showing all optional blocks for the azurerm_firewall_policy resource with Premium SKU, including dns, identity, insights, intrusion_detection, threat_intelligence_allowlist, tls_certificate, explicit_proxy, and related supporting resources. Fixes hashicorp#15585
Collaborator
|
Hi @yosofbadr - as mentioned in #31006, we generally don't add multiple large examples in the documentation. The documentation examples are meant to serve as a basic starting point, not a complete usage example. For larger and/or more complex examples, the |
Author
|
Thanks for the review and the pointer to #31006, @sreallymatt. That makes sense — the docs examples should stay as a minimal starting point. Closing this PR; happy to re-propose this as an addition to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
azurerm_firewall_policydocumentation showing all optional blocks with Premium SKUdns,identity,insights(withlog_analytics_workspace),intrusion_detection(withsignature_overrides,traffic_bypass, andprivate_ranges),threat_intelligence_allowlist,tls_certificate,explicit_proxy,private_ip_ranges,auto_learn_private_ranges_enabled,sql_redirect_allowed, andtagsFixes #15585
Test plan